Skip to content
Submitted about 2 years ago

Card Detail Form

Felipe da Costa Malaquias•160
@FelipeDaCosta
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive card details form
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

How can I improve this?

Community feedback

  • Adriano•38,270
    @AdrianoEscarabotePosted about 2 years ago

    Hi Felipe da Costa Malaquias, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    1
  • Ahmed•0
    @AhmedTirhmertPosted about 2 years ago

    good job, you nailed it on the first try.

    I like the design and the javascript interactivity, it is smooth and clean, I didn't get a chance to look up the code but i believe you did a good job structuring it.

    good job over all the responsive part needs more work since most web browsers are phone users.

    good luck. keep up the great work

    1
  • Aymen•220
    @AymenfisherPosted about 2 years ago

    Nice job mate , especially in the JavaScript part.

    I liked the interactivity and the clean JS code.

    In general, great work. One little issue is the responsive design on some devices , try the Devtools with different devices(like Galaxy s20 ultra ...etc) then try to solve the issues.

    I wish you good luck.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord