Card Component (Vanilla CSS/Grid)

Community feedback

• 

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  Nice job on your first challenge Juan congrats, just a few things to point out, you can use a property called "line-height" to give some separations to your lines to make the card a little more readable, and you can set some margin at the body that will separate the card from the border of the browser and make it more responsive, great job using grid-template-areas and great job using rem units to specify sizes

  1

  ---

  

  Juan Alvarez•60

  @alvarezj-devPosted over 3 years ago

  @Comet466 Hey, thanks! I think I couldn't use line-height in the right card, since I'm using differents p tags for each line - either way, I think I can add some margin to it. Also, not using margin with the body just because I used flexbox to center the card.

  I also saw your card implement and it seems nice! Good work

  1