@lack21
Posted
Good work 👍, but I have some recommendations!
- The problem with image is that
height: 100%
in the.cart-img
is not working in this case because the parent's height is not defined! Setheight: 450px
to the.card
and setbackground-size: cover
to the.card-img
, this should make it work! - Also replace
height: 100vh
tomin-height: 100vh
in thebody
, the difference is that, when you setheight: 100vh
to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh
, like this in case content is overflowing container will adjust to it.
Marked as helpful
@matiasluduena23
Posted
@lack21 Thank you Lucas! That was the problem.
And I also changed the height
of the body to min-height
so the element can grow if is necessary.