Card component using HTML and CSS

Community feedback

• 

  Peter Hannell•200

  @peterhannellPosted over 2 years ago

  Hi Chloe, I'm a fellow learner but I can offer some feedback/advice.

  Firstly make sure you include enough 'landmarks' in your HTML - these are tags like main nav footer etc., that define sections of content in your page which greatly improves accessibility for assistive navigation technologies such as screen readers. For example, you should wrap your 'attribution' class in a footer tag.

  You should also try to make your class names a bit more descriptive; for instance 'header' is a very generic and could refer to any header section within your page. This could be somewhat confusing when it comes to maintaining code later on. Maybe something like 'card__header' would be more appropriate just as an example.

  Finally, try to avoid the use of px for sizing everything in your CSS. You can certainly use it in some cases but most of the time will you want to use rem (and also em in specific cases) which is scalable and respects the users' browser font size preferences.

  But other than that you've done a great job! I hope my comment was helpful.

  Marked as helpful

  1

  ---

  

  Chloe•20

  @chloeafpPosted over 2 years ago

  @peterhannell Thanks for your advice. Everything makes 100% sense!

  1
• 

  Ronaldo•440

  @marckesinPosted over 2 years ago

  Hi Chloe. Your solution is pretty good on desktop mode but it doesn't have a mobile mode. You could implement media queries to solve that.

  1

  ---

  

  Chloe•20

  @chloeafpPosted over 2 years ago

  @marckesin Thanks for your feedback!

  0