Card Component using HTML and CSS
Design comparison
Solution retrospective
What do you think of the structure of the HTML codes that I used? Are there any problems with responsive design?
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there π. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
HTML π·οΈ:
- Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source π
Alt text π·:
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - @Zy8712Posted about 1 year ago
Your solution is very solid and pretty much identical to the original design, nice job!!!
The only thing I think I'd add in is the usage of a <main> tag. This would be for the sake of accessability. You can read more about accessible design here.
Marked as helpful0 - @Zohid-JurakulovichPosted about 1 year ago
Dear Bryan, thank you so much for your feedback. It helps me understand my mistakes while creating projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord