Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Card component using flex

Valper 150

@ValperDev

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello guys, i just finished this project and all feedback is welcome from html structure to class naming, loading fonts, best practices in html / css, etc... Thank you.

Community feedback

@ratul0407

Posted

@ValperGT congratulations on completing this challenge🎉🎉

Your solution looks pretty decent but you need some code improvements:

  • Every page should have a main tag. So Wrap you entire .card-container inside of a main tag.
  • You've used pixels, rems and ems on your site. But using px on paddings doesn't seem a good idea to me. And if you want to decide between rems , ems, and pixels here's an article deep diving into it. should you use px vs rem vs em

I hope you found this helpful👍👍

Have a nice day and happy coding🙂

Marked as helpful

2

Valper 150

@ValperDev

Posted

@ratul0407 Thank you :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord