Design comparison
SolutionDesign
Solution retrospective
Hello guys, i just finished this project and all feedback is welcome from html structure to class naming, loading fonts, best practices in html / css, etc... Thank you.
Community feedback
- @ratul0407Posted 11 months ago
@ValperGT congratulations on completing this challenge🎉🎉
Your solution looks pretty decent but you need some code improvements:
- Every page should have a
main
tag. So Wrap you entire.card-container
inside of amain
tag. - You've used pixels, rems and ems on your site. But using px on paddings doesn't seem a good idea to me. And if you want to decide between rems , ems, and pixels here's an article deep diving into it. should you use px vs rem vs em
I hope you found this helpful👍👍
Have a nice day and happy coding🙂
Marked as helpful2 - Every page should have a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord