Rajaul Islam Ratul• 1,250
@ratul0407
Posted
@ValperGT congratulations on completing this challenge🎉🎉
Your solution looks pretty decent but you need some code improvements:
- Every page should have a
main
tag. So Wrap you entire.card-container
inside of amain
tag. - You've used pixels, rems and ems on your site. But using px on paddings doesn't seem a good idea to me. And if you want to decide between rems , ems, and pixels here's an article deep diving into it. should you use px vs rem vs em
I hope you found this helpful👍👍
Have a nice day and happy coding🙂
Marked as helpful
2
Valper• 150
@ValperDev
Posted
@ratul0407 Thank you :)
1