Card component using BEM and CSS custom properties

Community feedback

• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hello there 👋 @elisilk.

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  Consider adding a min-height of 100vh to the body element so as to centralize your project.

  body { 
    min-height: 100vh;
    align-items: center;
    display: flex;
    justify-content: center;
  }
  
  

  I hope this suggestion is useful for future projects.

  Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! 🚀🌟.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0

  ---

  

  P

  Eli Silk•660

  @elisilkPosted 9 months ago

  @Ezekiel225, thank you so much for the great feedback. I have started using the Perfect Pixel browser extension and it has definitely helped me identify very specific ways that my solution differs from the design. Super helpful. And I implemented the flex solution for centering the full content within the viewport. Very elegant solution for that. I really appreciate the help!

  0