Card Component - HTML5, SCSS, Grid, Flexbox and BEM

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Juan Bonilla! My name is Vanza!

  I have some feedback that will improve this solution:

  • Don't set the html font-size, especially using px, leave as it is. The reason for that is because it will not allow the user to change the font-size base on their setting.
  • Try to set box-sizing: border-box on all elements using * universal selector. It will prevent the element from adding width when you add padding.
  • As you can see from the design comparison, the box-shadow need to be lighter.

  That's it! Hopefully this is helpful!

  Happy Coding!

  2

  ---

  

  Juan Bonilla•610

  @juanpb96Posted over 3 years ago

  @vanzasetia Thanks Vanza for commenting in my solution! 🙌

  I have done everything you recommend. Those were good suggestions to keep in mind for my next challenges.

  Happy coding too!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  @juanpb96 I checked this solution and now it's much better. 👍 Good Job!

  0