Card Component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @SinthMite!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <div>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  0
• 

  raya•2,850

  @rayaattaPosted 10 months ago

  Hello Sinth, congratulations on completing this challenge 🎉

  I have some suggestions to help improve your code.

  1 I noticed that your card expands a lot on big screen devices.it would be best if you give it a max-width. You could add

  max-width:min(90%,21rem)

  to

  .second-background

  2 Divs carry no semantic value therefore you should replace

  <div class="equlibrium"> with <h1 class="equlibrium">

  And <div class="paragraph">

  with

  <p class="paragraph">

  I hope this helps 🙃 Again great solution!

  0