Skip to content
Submitted 6 months ago

Card component

Christian R•20
@ChrisJRM92
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Results summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Along the way completing this challenge it helped me understand many things, such as CSS layout and consuming data from a .json file using javascript, in my next challenge I will use grid box to better understand the layout of a web page.

What challenges did you encounter, and how did you overcome them?

A challenging challenge for a learner, the biggest challenge was the issue of responsive design, data consumption from the .json file and obtaining the average result of all the values with javascript, overcome these challenges with the help of chatGPT as a guide and remembering the fundamentals of javascript.

What specific areas of your project would you like help with?

I would like to know more about javascript and data consumption, also in a future challenge use React for the creation and reuse of components.

Community feedback

  • Daniel 🛸•44,250
    @danielmrz-devPosted 6 months ago

    Hello there!

    Congrats on completing the challenge! ✅

    Your solution looks excelent!

    I have just one suggestion:

    📌 To improve semantic clarity, try your best to stick to one <h1> per page for the main title.

    It's more than just text size — it's about structuring your content effectively:

    • <h1> to <h6> are used to define HTML headings, with <h1> being the most significant.
    • And maintain the titles hierarchy with <h1>, <h2> <h3>, and so on.

    While these adjustments might not alter the visual appearance much, they significantly enhance semantic clarity, SEO optimization, and accessibility.

    Hope this suggestion proves helpful! Keep up the great work!

    Marked as helpful
    1
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 6 months ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    BODY MEASUREMENTS 📐:

    • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.
    • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.
    • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
    • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    1
    Christian R•20
    @ChrisJRM92Posted 6 months ago

    @0xabdulkhalid Thank you for your suggestions, this is my second challenge and I still have a lot to learn, I will implement these improvements in the challenge, best regards

    0
    Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 6 months ago

    @ChrisJRM92 Glad you found it helpful ! 🤠

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord