Card Component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The background image needs to be applied via CSS using the background-image property.

  • The “Illustration” and Music Icon serves no other purpose than to be decorative; they add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hide it from assistive technology.

  • The only heading in this challenge is the ”Order Summary". Every other text should wrapped in a Paragraph Element.

  • The "Cancel Order" was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  P

  Farel Deksano•170

  @digiT000Posted about 2 years ago

  @vcarames Hi thank you so much for your suggestion, it really means to me. I wanna ask about the background image, honestly, I never apply images from CSS I always use tag <img>. Is there any advantage or reason why use a background- image to apply the an image?

  Thank you again

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  @digiT000

  Glad I could help!

  It is best practice. Only vital content should be in the HTML. Anything that is decorative should be in the CSS.

  There are some times, where you have to add an image/icon that is decorative on the HTML because this is the only way that it can styled properly. When this is done, you have use accessible elements to delete it from screen readers.

  Marked as helpful

  0

  

  P

  Farel Deksano•170

  @digiT000Posted about 2 years ago

  @vcarames Ohh okay understood, so better go with background-image for decorative things, but if that can't be done with CSS uses tag <img> but hide it from the screen reader for better usability.

  Thank you so much for your explanation, really help me a lot with my front-end dev journey 🙏 🚀

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  @digiT000

  Correct!

  0