Card

Community feedback

• 

  Manish Singh•230

  @manishsinghrajPosted 7 months ago

  Good work.

  You can utilize the <main> element to serve as the background, (bg-yellow), and introduce another <div> element for the card, (bg-white).

  Then, systematically include elements within this card, such as the image and text. This will help in readability and a well-structured codebase for developers to read.

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 7 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your project is looking fantastic!

  I'd like to suggest a way to make it even better:

  • Using margin isn't always the most effective method for centering an element.

  Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

  📌 Apply this CSS to the body (avoid using position or margins in order to work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  I hope you find this helpful!

  Keep up the excellent work!

  0
• 

  P

  sampath-karupakula•30

  @sampath-karupakulaPosted 7 months ago

  1. Does the solution include semantic HTML? Yes. 2. Is it accessible, and what improvements could be made? looks good, but author alignment is not proper. 3. Does the layout look good on a range of screen sizes? No, Layout needs to be improved. 4. Is the code well-structured, readable, and reusable? code is well structured and readable. 5. Does the solution differ considerably from the design? with UI reference, solution is differ in terms of placement vertically.

  0