Design comparison
Solution retrospective
Hi,
This was my first time using context API, which I used to set up a theme system. If possible kindly check my code and the live project and give any suggestions for further improvement.
Thank you
Community feedback
- @calliou24Posted over 2 years ago
You did a good job, and is very interesting the use of the context API, i've never see it this way before, Congratulations!!
Personal feedback :
I think is it a good practice to write the code simple as possible, that includes not to separate in components all the part of the app, i mean (inputs, buttons) this way is easier to read for other devs, also would be very interesting to implement an error management ( not returning infinity when your divide by zero, the feature that allows the user to only write a operator value like [ + - / * .] once after a number, and returning the result without the decimals -- but this is just preference ).
Marked as helpful0@anmol1468Posted over 2 years ago@calliou24 Thank you for your feedback, I would definitely work on some of the suggestions you gave.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord