Calculator using nuxt 3

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi George, great work in building this calculator! I just got some quick comments for you after playing around a bit with it:

  1. I'm viewing this on my laptop and the bottom is cut off a bit; this is because you used height: 100vh instead of min-height. You can check this by resizing the browser window to be a bit shorter than the content. Try changing it to min-height and see if that works, and try to add a bit of top and bottom margin to help add some spacing.

  2. I think I see that you're using eval() in your code; I also did that first but eventually I changed it to a switch statement. I'd caution against using eval(), which is something you can read about on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval

  Hope some of this can help you!

  1

  ---

  

  George Mushore•310

  @tenderkingPosted about 2 years ago

  @elaineleung hi thanks for the comment, I fixed the styling issues, hopefully ythey shoud be good on your laptop. the eval() i didn't knoww about that, I'll have to think about it and how to implement it.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 2 years ago

  Hi George. Nice work on your calculator . Here are some improvements you can make:

  • Press any digits continually and watch the whole layout break, at the same time a calculator should have a maximum number that it can take, we can not have a calculator that can accept digits as long as one can press a key.
  • prevent this 0.11.32.39 with some conditions that allows not accepting more that one decimal point.
  • try the following calculation 0.1 + 0.2

  Happy Coding

  0