Calculator using eval method

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 1 year ago

  Hi Nicolas

  • your html at the moment does not make your calcualtor accessible. It is very important to use semantic html to improve the accessibility of your project. Click events should not be placed on div elements - a div is a general element with no important meaning for assistive technology. That is to say , the operators and operands should be buttons. The theme switcher should be created using radio buttons
  • you only need to have one css reset stylesheet
  • font sizes are recommended to be in rems or em. Read more here Why font sizes should never be in px
  • this calculator should only accept numbers and the operators. At the moment I can enter a word or as many decimal points as I can, another reason why eval is not good to perform such calculations.
  • There is not enough space at the top and bottom of the calculator. Some of the content is cut off at the top.

  Marked as helpful

  1

  ---

  

  Nicolas•250

  @nicolas055Posted about 1 year ago

  Hello ChamuMutezva. Thank you for your feedback!!!

  I sent another solution to this challenge, this time I tried to follow your tips and redid all the calculator's features.

  • I used the math.js library to parse the result
  • I used the <button> tag to make the keyboard eventListeners.
  • I also fixed the space at the top and bottom of the calculator. Now the content is no longer cut off.
  • Converted all font size values from px to rem.

  You helped me a lot. Thank you very much!!!

  0