Calculator

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 2 years ago

  Hi Tomisin Awoniyi. So far so good, here is my observation:

  HTML

  • as mentioned by @AdrianoEscarabote, some elements are more important than others as they give meaning to your project, elements such as the main are considered important as that is where the the central functionality of an application is contained. The divs and related elements should be elements of last resort - a div has no semantic meaning.
  • Generally a site should have an h1 heading element as the first heading element with the rest following a sequential order without skipping headings.
  • since the theme switcher has 3 options, the best elements to use , in my opinion, will be a set of radio buttons - a checkbox is not suited in this instance.

  JS

  • try the following calculation 0.1 + 0.2
  • yes the calculator should have a maximum number that it should take , you can set a condition using display.textContent.length such that it should not be greater than a certain length.
  • make sure to have the condition that allows not more than one decimal point as in the following 6123....... and the same as the order of operators , eg 6123.......++++++***0

  Happy coding

  Marked as helpful

  1

  ---

  

  Tomisin Awoniyi•90

  @tomisin2kPosted about 2 years ago

  @ChamuMutezva WOW! Thank you so much!!!

  0
• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi Tomisin Awoniyi, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- All page content should be contained by landmarks, you can understand better by clicking here: click here

  2- Document should have one main landmark, you could have put all the content inside the main tag click here

  I noticed that the content is not centered to fix this we can do the following:

  I added:

  body {
      display: flex;
      justify-content: center;
      min height: 100vh;
      align-items: center;
  }
  

  The rest is great!!

  Hope it helps...👍

  Marked as helpful

  0

  ---

  

  Tomisin Awoniyi•90

  @tomisin2kPosted about 2 years ago

  @AdrianoEscarabote Thank you Adriano!!! I appreciate and thank you for sharing your light brother, one love man!

  1

  

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  @tomisin2k thanks man, keep coding!

  0