Design comparison
Solution retrospective
That was a good challenge. I learned a lot about setting themes. The theme is saving in local storage, and the browser will remember you choise. I made a little push button animation. The calculation function was a bit tricky, If you find any error please let me know. I made a function to prevent from typing more than one dot in a number, and a function that replaces the operator character if you type another operator.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
JAVASCRIPT 🟡:
- Looks like the some variables and it's data are logging at developer console due to the
console.log(). it's an issue to haveconsole.log()statements in a finished web application.
- This is because
console.log()statements are used for debugging purposes, and they are not intended to be seen by users. Whenconsole.log()statements are left in a finished web application, they can reveal sensitive information to users, such as the values of variables or the structure of the application's code. This can make the application vulnerable to attack.
- So please remove those
console.log()statements from the application as soon as possible. then we can completely remove the risk of sensitive information being exposed to users.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@SoulRvr29Posted over 1 year ago@0xAbdulKhalid
Thanks for the advice, I removed the console log.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord