Calculator app using React and Sass

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Not bad at all. Seems like most of the logic works. The main thing that was irritating was the display going back to 0 after hitting the operator chosen. So 6 shows 6 then hit the + key and the display goes to 0. The real calculator beside my desk would have still shown the 6 until another number was chosen

  if you want to challenge yourself you should add in the keyboard inputs

  2

  ---

  

  Beygs•130

  @BeygsPosted over 3 years ago

  @palgramming Thanks for the feedback, I also looked at a real calculator before doing the display that had this « back to zero » thing going when I hit an operator. I will try other display options. Also I didn’t had the time yet to add keyboard inputs, but it was on the todo (I’m doing it today) 😉

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Beygs ok really interesting how Calculators all function a little different in real life. Well then do not worry about my zero comment

  1

  

  Beygs•130

  @BeygsPosted over 3 years ago

  @palgramming I updated it, what do you think of it now?

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Beygs It looks really good nice job. It is much clearer

  0

  

  Beygs•130

  @BeygsPosted over 3 years ago

  @palgramming Wonderful thanks a lot!

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Beygs! 👋

  Well done on this challenge! Today I finished this challenge also. Besides palgramming good feedback here's a few things I'd suggest you to take a look at:

  • Display some error message after user divide by zero instead of default javascript "infinity".

  Keep up the good work! 💪

  1

  ---

  

  Beygs•130

  @BeygsPosted over 3 years ago

  @tediko Hi! Thanks for your feedback and for the idea! I just finished implementing this. I also added keyboard inputs if you want to check, and I'm going to check your solution.

  1

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @Beygs Haha, good job! 🤩 Now I find other problem (sorry!). When divide by zero error pop up and I click + (or any other sign) it is adding NaN + number and the result of that is NaN obviously. Maybe try reset your calc after this divide error.

  0

  

  Beygs•130

  @BeygsPosted over 3 years ago

  @tediko Oops! I forgot to test this possibility, thanks for pointing it out!

  0