Calculator App using HTML, CSS, JS

Community feedback

• 

  Nads•390

  @NADS-PROGRAMMERPosted almost 3 years ago

  Hey Jon! Really well done!

  I notice some issues:

  First, so I test your calculator app, so the user can't type in the keyboard?

  Second, I notice you also code in JavaScript for the hover effect, I think you can also do that in CSS. So, if the user changes the theme, you can use the classList attribute to toggle the classes for a certain theme.

  Third, for the theme button, I think it is better to make the numbers clickable so that the user doesn't have to click on the toggle button. It is also for accessibility purposes, since you are using a button for the toggle's circle, you can use a <label> tag to point to a certain button so that the user can click the number.

  Marked as helpful

  1

  ---

  

  Jon•60

  @Jon-LedoPosted almost 3 years ago

  @NADS-PROGRAMMER Thanks for the advice and taking the time to look it over! It completely slipped my mind that people may want to use the keypad to interact with the calculator, that sounds like a great stretch goal to do next.

  I initially had some trouble getting the multiple over effects to work with plain CSS, so I just defaulted to doing a lot more JS heavy stuff. That is the one thing I want to change once i refactor. Thanks for the tip on how to approach it, I think I know how to better implement the style changes next!

  I really like this idea for the toggle too, when I wrote the html for it I didn't give it much thought because I was so preoccupied with the JS. It's the one aspect of the project I truly want to remake from scratch. The accessibility purposes alone is reason enough.

  Thanks again : )

  0