Calculator app using GULP, SASS, JS, BEM, HTML, RESPONSIVE DESIGN

Community feedback

• 

  Cameron Chandler•850

  @webstormcamPosted almost 3 years ago

  Hi Roman,

  I know that you built this along time ago but I really think that you did an awesome job on this project.

  I hope you continue to build!

  Marked as helpful

  0

  ---

  

  Roman Zvir•290

  @rmzvrPosted almost 3 years ago

  @webstormcam Thank you very much, I am pleased to receive feedback after a long time, especially on pet projects. I am currently learning React)

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  You need to change the markup for the theme switcher to make it accessible. This is only suited to 3 radio inputs, and the numbers are their labels. You can’t have an empty label as you have at the moment, it’s very confusing for assistive tech users.

  The calculator works nicely though and looks good. Well done 😊

  Marked as helpful

  0

  ---

  

  Roman Zvir•290

  @rmzvrPosted over 3 years ago

  @grace-snow thanks a lot for the hint, I noticed that the slider looks different on different devices, but resetting the styles does not solve this problem, I'll have to follow your advice and make the slider using radio buttons

  0

  

  Roman Zvir•290

  @rmzvrPosted over 3 years ago

  @grace-snow fixed the errors you pointed out and changed the theme switcher, if it does not bother you, please check the result :)

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  you also need to limit the . so users cannot enter numbers like this 1.2.3.4.5.6

  Marked as helpful

  0

  ---

  

  Roman Zvir•290

  @rmzvrPosted over 3 years ago

  @palgramming thanks for pointing out the error, I fixed it :)

  1