Calculator app using grid & css variables and js

Community feedback

• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  Hi, Following are some issues i like to point out:

  • On entering higer no, number overflows. To avoid you can use "word-break:break-all".
  • Try to use semantic HTML tags as much as possible for better accessibility. Like in your case to wrap the main content use <main> tag instead of <div>
  • Text is not property aligned inside the button. If you care using fixed height for the button, use flex to center else use padding-top and padding-bottom to center the text. For flex you can do tihs

  button{
    height:50px;
    display:flex;
    align-items:center;
    justify-content:center:
  }
  

  • If number is not present do not allow user to choose operation.
  • Operation should not repeat. (+++++). This makes no sense.

  I have also completed this challenge. You can look into it just for reference.

  Good luck,

  Happy Coding

  Marked as helpful

  1

  ---

  

  morteza•230

  @mooryxPosted over 2 years ago

  @besttlookk thanx for the feedback ill try to fix these issues

  0
• 

  Ramz•375

  @Ramz001Posted over 2 years ago

  Good job completing this challenge !

  0