Calculator app built with HTML | CSS | JS - MikDra1

Community feedback

• 

  P

  Teodor Jenkler•3,820

  @TedJenklerPosted 3 months ago

  Hi @MikDra1,

  Nice project! I’m planning to do this one myself soon. I noticed that you can use a dot (.) before any number is entered.

  As an extra improvement, I’d recommend adding a useRef to make the buttons controllable with arrow keys. This would make the project more accessible and even more impressive.

  Hope this was helpful!

  Best, Teodor

  Marked as helpful

  1

  ---

  

  MikDra1•6,980

  @MikDra1Posted 3 months ago

  @TedJenkler

  Dot is perfectly fine. If you write dot as a first value the JS will assume that you want zero before it ☺️

  As you can see in the code I’m not using React, but I am planning to do this project soon in React. Maybe then I will use your advice.

  1

  

  P

  Teodor Jenkler•3,820

  @TedJenklerPosted 3 months ago

  @MikDra1: My bad—I only checked the responsiveness and functionality. It's still possible to do with key event listeners and DOM manipulation, but it’s much harder.

  Have a nice day / Teodor

  0
• 

  Yulia•400

  @YuliaLantzbergPosted 3 months ago

  Hi. It's looking and working great. Just maybe it's better to make a guard preventing division on 0. Also, the dot is not working on the keyboard. About the js, I'd add one class to the "calculator__grid" div and in CSS would target the child divs through it. Then in js it'd take less code lines to add and remove all the classes. But all that are minors. Your work is really good as always. I'm learning a lot from your challenges. I hope I will get to this challenge soon.

  Marked as helpful

  0

  ---

  

  MikDra1•6,980

  @MikDra1Posted 3 months ago

  @YuliaLantzberg

  Thanks for kind words 😁. For classes it might be a good approach. I haven't thought about it. Anyway, if you will do this project soon you can try doing this 😉

  1

  

  Yulia•400

  @YuliaLantzbergPosted 3 months ago

  @MikDra1 Sure I will hehe

  0