Babantos• 300
@sotnab
Posted
Hi,
Your project looks cool, but there is a lot things to improve. Sizes of fonts and elements are much different than in design. Some elements arent centered, and well-positioned.
I really like your slider which runs smooth.
<p class=" tggl" id="tggl_1" onclick="toggle(this)">1</p>
<p class=" tggl" id="tggl_2" onclick="toggle(this)">2</p>
<p class=" tggl" id="tggl_3" onclick="toggle(this)">3</p>
Never cast function to js events in html. Script should be separated from html document.
In this case you can get these elements by document.querySelectorAll('.tggl') and add listeners to every item in loop.
There are some other issues like duplicated id's or typos in names but i hope you are going to fix it asap.
Keep it up
Marked as helpful
0
