Calculator App

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  while it says invalid expression on you try to add this 1.1.1.1.1.1.1+1.1.1.1.1.1.1 I think the key here is to not let the user enter things that are not valid like the multiple "....." to start with

  The logic in this project is not easy there are lots of little gotchas in it. So far you have done a good job just needs so fine tuning

  2

  ---

  

  Rodrigo Vitoriense•100

  @rodrigorvixPosted over 3 years ago

  @palgramming, thanks for your feedback! I will try to implement your suggestions.

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi there, Rodrigo Vitoriense! 👋

  Good job on this challenge! 👏 Your solution looks good and the calculator seems to be working pretty well! 👍

  I suggest clearing the "invalid expression" text when the user begins typing a new expression after that (so that they don't end up with something like invalid expression9 + 2 on the calculator). Besides that, I think making the theme toggle keyboard accessible would be a good idea, too. 😉

  Overall, everything works nicely! 😀

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  Rodrigo Vitoriense•100

  @rodrigorvixPosted over 3 years ago

  Hello, @ApplePieGiraffe!!

  Thank you very much for the feedback. I will try to implement your suggestions in the project.

  0