Calculator App

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Hi Harsh’s

  Nice work on this Challenge. Most of the functionalities are working as expected . Here are some views from my end:

  • one more push on the design - the desktop is a bit smaller than the original
  • the site is responsive, well done
  • you need to style for focus state, i cannot tell where the focus is when i am using the keyboard. Remember some users rely on keyboard as a means of interaction
  • The theme switcher will not work with a keyboard or other assistive technology devices because you used a div . It is important to use semantic elements where ever possible. I would recommend using radio buttons for the theme switcher.
  • .app .calculator .header .themeBtn .themeBtn__container .themeBtn__switch , this css nesting can be problematic to debug and maintain. You can simply use .themeBtn__switch on its own or with the .app parent that is if has to do with the theming functionality.
  • set a maximum number that the calculator can take to avoid overflowing, at the moment i can enter as many as i want.
  • do the following calculation 0.1 + 0.2
  • try also to enter any number followed by a dot then any number and some zeroes then a number eg 2.400005 . I expect you to find that the display does not update when entering the zeroes, it will update correctly when you enter the number after the zeroes.

  P.S. i am working on the same challenge, not yet done with bugs

  Happy coding

  Marked as helpful

  0

  ---

  

  Harsh•170

  @harsht67Posted over 2 years ago

  @ChamuMutezva Thank you for pointing these bugs/fixes out. I will try to fix them asap. And good luck with your challenge.

  1