Design comparison
SolutionDesign
Solution retrospective
I forgot to use scss😥 where can I improve my javascript code?
Community feedback
- @ChamuMutezvaPosted about 2 years ago
Greetings Github48
So far so good, here is an observation from my end:
- heading elements should follow a sequential order with the h1 being the first heading element , followed by an h2 and so forth.
- for the toggle , I recommend using radio buttons for the reason that , they allow one selection at any particular time, which is what we need.
- let the calculator have a maximum digit that it can contain, we can not have a calculator that can take any number as long as you click.
- try the following calculation
0.1 + 0.2
- so i tried
12 + 36
but now click thetimes
sign and see what happens. That is12 + 48 x
- Good work at least one decimal point can be selected.
- Well done , the site is responsive
- comment out or remove the
debugger
statements in your javascript files - keep styles in your css files , but add the relevant changes with js using classes eg
outputs.classList.add("new-style")
Happy Coding.
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord