Calculator App

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Add a background color in .calculator class

  Marked as helpful

  1

  ---

  

  uiGuy•255

  @uiGuysPosted about 3 years ago

  @afrussel OK

  0
• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Also on .theme class make border: 0

  2

  ---

  

  uiGuy•255

  @uiGuysPosted about 3 years ago

  @afrussel alright

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted about 3 years ago

  You should limit the . key so on each value entered to be calculated there can only be one . in each entry and so the user cannot enter a number that looks like this 1.2.3.4.5.6.7.8.9

  1
• 

  LetsFrontend•500

  @B1N4R1Posted about 3 years ago

  Hi uiguy,

  Great solution to the challenge! Both the layout and the calculator logic are great.

  Here some little suggestions:

  • I would get rid of the max-width: 770px on the 600px media-query the calculator looks too stretched to my eyes.
  • I would avoid letting the user type in multiple periods (......). This is causing some problems when making calculations. Like for example you can calculate 8 + 6...... which is giving some syntax error.

  Btw, nice work with the theme toggle too.

  Cheers!

  0