Design comparison
Solution retrospective
1]I was not able to center the image without using flexbox , could anyone suggest any other idea to do it ? any suggestions are welcome .
Community feedback
- @jen67Posted 10 months ago
Hi @Rrdesh07,
Your code and card design are well done! To center an image without using flexbox, you can try using the
text-align
property on the parent container and setmargin: 0 auto;
for the image. This centers the image horizontally within its container. Here's an example:.card { text-align: center; } img { max-width: 100%; display: block; margin: 0 auto; /* Center the image horizontally */ } Feel free to give it a try, and let me know if it helps!
Marked as helpful2@Rrdesh07Posted 10 months ago@jen67 Hey , Thank you for your suggestion, i was doing it in wrong way because of lack of understanding in shorthand of margin , now i got it where i was going wrong , Thank you :)
1 - @danielmrz-devPosted 10 months ago
Hello @Rrdesh07!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>
to<h6>
tags are used to define HTML headings.š
<h1>
defines the most important heading.š
<h6>
defines the least important heading.š Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
Marked as helpful1@Rrdesh07Posted 10 months ago@danielmrz-dev Thank you sir , noted down your suggestion ,will remember while doing other projects , thanks for your guidance :)
1 - In order to make your HTML code more semantic, use
- @TigoPPosted 10 months ago
take a look ain my code, maybe it can help you. but yours is awesome too
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord