Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

By html and css

@BhatNishanthGanesh

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Most of the parts are done, but responsive part isnt correct enough, its only proper for some devices. Please feel free to let me know the error and to improve this code

Community feedback

@Kamlesh0007

Posted

Congratulations on completing the challenge!🎉. That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. bro for responsive design remove this lines ofcode

@media (min-width: 769px) and (max-width: 1024px)
{
.cover {
/* margin: 4rem; */
/* margin-left: 23rem; */
/* margin-right: 23rem; */
/* padding: 0 1em 2em 1em; */
}
}
@media (min-width: 1025px) and (max-width: 1280px)
{
.cover 
{
/* margin: 4rem; */
/* margin-left: 33rem; */
/* margin-right: 33rem; */
/* padding: 0 1em 2em 1em; */
}
}
.cover {
/* margin: 6rem 35rem; */ remove this line
/* padding: 1em 2em 1em; */ remove this line
padding:1rem // add this line
}
.img-size {
max-width: 280px; add this line
border-radius: 1em;
/* margin-top: 2em; */  remove this line also
}
add this code to make container. center as per design

body
{
display: grid;
grid-template-columns: 1fr;
min-height: 100vh;
place-items: center;
}

Marked as helpful

0

@BhatNishanthGanesh

Posted

@Kamlesh0007 , ya i removed it, still its not completely responsive. I have to check it out. Thanks for the suggestions

0

@Kamlesh0007

Posted

@BhatNishanthGanesh all the commented code u have to remove and only add body tag code for making it center and also add the line where I told that add this line

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord