By html and css

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge!🎉. That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. bro for responsive design remove this lines ofcode

  @media (min-width: 769px) and (max-width: 1024px)
  {
  .cover {
  /* margin: 4rem; */
  /* margin-left: 23rem; */
  /* margin-right: 23rem; */
  /* padding: 0 1em 2em 1em; */
  }
  }
  @media (min-width: 1025px) and (max-width: 1280px)
  {
  .cover 
  {
  /* margin: 4rem; */
  /* margin-left: 33rem; */
  /* margin-right: 33rem; */
  /* padding: 0 1em 2em 1em; */
  }
  }
  .cover {
  /* margin: 6rem 35rem; */ remove this line
  /* padding: 1em 2em 1em; */ remove this line
  padding:1rem // add this line
  }
  .img-size {
  max-width: 280px; add this line
  border-radius: 1em;
  /* margin-top: 2em; */  remove this line also
  }
  add this code to make container. center as per design
  
  body
  {
  display: grid;
  grid-template-columns: 1fr;
  min-height: 100vh;
  place-items: center;
  }
  

  Marked as helpful

  0

  ---

  

  BhatNishanthGanesh•50

  @BhatNishanthGaneshPosted over 1 year ago

  @Kamlesh0007 , ya i removed it, still its not completely responsive. I have to check it out. Thanks for the suggestions

  0

  

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  @BhatNishanthGanesh all the commented code u have to remove and only add body tag code for making it center and also add the line where I told that add this line

  Marked as helpful

  0

  

  BhatNishanthGanesh•50

  @BhatNishanthGaneshPosted over 1 year ago

  @Kamlesh0007 thanks

  0