
Design comparison
Solution retrospective
Another RWD project delivered! I've taken the "mobile first" approach - the key takeaway is that you always need to plan at the very beginning and implement HTML structure for the desktop version of the site (not only mobile one).
At certain point I got stuck with implementing additional classes for Desktop purposes (already after finishing the mobile version of the website), what had complicated making the structure consistent but eventually I managed to close the project.
Any suggestions to improve the code are welcome.
All the best and happy coding! Kamil
Please log in to post a comment
Log in with GitHubCommunity feedback
- @vanzasetia
Hi, WiaterKa!
I recommend using a code-formatter. This way, your code base will have a consistent format, which makes it easier to read the code. I suggest using Prettier as your code-formatter.
Prettier · Opinionated Code Formatter
Alternative text for images should not contain any words related to "image" (such as picture, photo, logo, icon, graphic, avatar). It is already an image element (
<img>
) so the screen reader will pronounce it as an image.Keep in mind that alternative text will be read by humans. So, you need to make sure that they are in human-readable format, not like code.
Not every image needs alternative text. Decorative images should not have alternative text (
alt=""
). This will tell the screen reader to skip over the image. As a result, it saves screen reader users time navigating the page.For your information, decorative images are images that don't add any information and serve only aesthetic purposes.
For the dark logo, you can create a new SVG file and change the color. You can change the color by searching the
fill
property inside the SVG file.The list inside the
<footer>
should be a list of navigation links. So, you should wrap the list with a<nav>
landmark. Then, wrap each text with an anchor tag.I hope this helps. Happy coding! 😄
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord