Skip to content
Submitted almost 3 years ago

Built with HTML 5 , CSS 3 , Sass ( CSS pre-prossecor )

Abo Abaass•120
@aboAbassAlshaege
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    Hey good job on this challenge! Your report above shows a few issues. You can fix them by

    • wrap everything in your body in <main> ... OR use semantic tags! .... you can also give role="" to the direct children of your <body> but that's a little frowned upon... Click here to read more
    • have at least one <h1> in your code

    :)

    0
  • Web Wizard•5,690
    @rsrclabPosted almost 3 years ago

    Hi, @aboAbassAlshaege ~

    Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

    Here are some of the tips I like to provide.

    • On smaller devices, card goes over screen, and I think max-width: 100% can solve this issue.
    • I suggest you to try transition on hoverable elements like image, heading and creator name.
    • Please try BEM for naming element classes. It will help you a lot on bigger projects.

    https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

    Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

    Cheers ~

    0
    Abo Abaass•120
    @aboAbassAlshaegePosted almost 3 years ago

    Welcome , @tymren608

    Thnaks for your advices and notes .

    I have alomost done all of the things that you told me , and saw your solution . It was useful , And i learned many things.

    Thanks again . I really appreciate that .

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord