Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h2> with <h1> to fix the accessibility issues.
Replace the height in .container with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement.
padding:16px
.For a responsive content replace the width in .container with max-width and give the img a max-width of 100% for a responsive content instead of a width and height value.
Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@kingchoffyPosted over 1 year ago@Hassiai thank you for your feedback. i have implemented the suggestions and i must say it looks muchbetter now
Thank you ❤
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord