Built with Create-react-app and sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, adluders! 👋

  Nice job on this challenge! 👏 I like the pretty gradients you used to color the social media icons in the footer of the page! 🙌

  I just suggest doing a little more work on the responsiveness of the site since currently, there are some issues when the width of the screen decreases. For instance, in the mobile layout of the site, a horizontal scroll bar appears along the bottom of the page (hiding some of the content from view) and the "GET AN INVITE" button in the header navigation of the page looks a little squished. Adjusting a few things in the header navigation to suit smaller screens should help. 😉

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @ApplePieGiraffe thanks for the feedback. I checked it on my phone and it seemed to work fine on landscape and portait. Do you mind telling me what screen size are you using that gives this issue?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @adluders

  Using Chrome's dev tools, the header seems to overflow the width of the page at around 600px and below. The rest of the page is actually fine—I think the navigation just isn't changing to a mobile-friendly version (like, with a menu icon and everything). Fixing that should do it, though, I think. 😉

  1

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @ApplePieGiraffe it's so weird to be honest. When I use the dev tools and resize, it looks crappy but when I go on the actual device, it looks fine. Any thoughts on what adjustments I can make to fix that?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @adluders

  TBH, I've experienced that exact same thing when working with Chrome's dev tools and I don't know what causes it. 🤨 I wish I could show you some screenshots or something, but there currently isn't a way to include images in comments on Frontend Mentor. IDK, does the issue appear when resizing the browser window itself on your desktop?

  1

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @ApplePieGiraffe it does but it's at like a random screen size so that's why I did not bother with it because it happened in a screen size that matters, like it does not affect tablets, or any phone size etc.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @adluders

  Alright, then. 😅 Overall, the solution's pretty great! Keep coding and have fun! 👍

  1

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @ApplePieGiraffe thank you. I appreciate it. I'm gonna look into a way to fix the problem though because the lack of consistency is annoying.

  1
• 

  Soumya Chalakkal•465

  @csoumya14Posted almost 4 years ago

  Hi, Nice attempt. I liked the way you build the table on the features page. I used that as a reference while doing this challenge. I would like to give one suggestion, using "<picture >tag" instead of "<img/> tag" will give you more flexibility in using images while working with a responsive design.

  1

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @csoumya14 hey I'm glad this could've been used as a reference for you. What do you mean by your suggestion?

  0

  

  Soumya Chalakkal•465

  @csoumya14Posted almost 4 years ago

  @adluders

  Sorry for the typo. I mean using a picture tag instead of an image tag will give you more flexibility.

  0

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @csoumya14 ah gotcha. I'll look into that. I have typically used the img tag so it was not even something I thought of to be honest

  0