Built using Flexbox

Community feedback

• 

  Veronika Palto•305

  @JepardMayPosted over 3 years ago

  Hello. Nice work with this project!

  If you wanna use min-height: 100vh, you needn't use height in % on container block. I recommend don't use height on this element and use margins and padding on container's children to get the needed height. Also don't use 'width: 10vw' and use 'width: 100%' to avoid unnecessary horizontal scroll on the page.

  I recommend don't use divs to add background images and use CSS styles instead for body or container cause these images are not given any information to the user.

  I also encourage you to think about if there will be more elements in both the top and the bottom sections. Now, if I add more cards, it wouldn't be looking nice.

  For cards offsets, you can use ':nth-child()' instead of classes, and for the top section use margin-right to avoid cards go off the container block.

  I hope my suggestions will be helpful. Keep coding :)

  Marked as helpful

  0

  ---

  

  Zeshan Abdullah•145

  @zeshanabdullah10Posted over 3 years ago

  @JepardMay Hi Thank you so much for taking out the time and giving me some valuable suggestions. They really are helpful for a newbie like me. Thanks again. Stay happy:)

  0