built by using CSS grid & flex.

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job in completing this project. Looking at your solution I would suggest the following for you...

  • It's best practice to specify the image size in the CSS style. Instead of inline style you could make another rule set with the following...

  .logo img {
    width: auto;
    height: auto;
  }
  

  • As you code your project, it's better to organized the file. Create another file solely for CSS style. Add the link to the head and eliminate the style property
  • Clean the whitespaces in your code
  • Wrap the container with specific tag like main and attribution with footer tag
  • Same goes with button instead of inline style you could emphasize the property in the CSS style from this... <button class="button" style="color:hsl(184, 100%, 22%) ;">Learn More</button> into

  HTML:
  <button class="button btn-1">Learn More</button>
  
  CSS:
  .button.btn-1 {
    color: hsl(31, 77%, 52%);
  }
  

  • Add the hover state for each button as well...

  .button.btn-1:hover {
    background: hsl(31, 77%, 52%);
    color: white;
    border: 2px solid white;
  }
  

  Hope this helps and Keep up the good work!

  Marked as helpful

  1

  ---

  

  Fai•140

  @FsaneaPosted almost 3 years ago

  Great feedback thanks a lot @RioCantre , I'll make sure to follow these instructions in the next challenge.

  1