Building QR code component with flexbox

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi! Excellent solution! 🙂

  • HTML (accessibility problems)
    • wrap your code in main tag or change div class="card" to main class="card"
    • change div class="attribution" to footer class="attribution"
    • alt should describe an image or its function and be empty only if it is only decorative, read more about alternative text here. In this challenge alt can be QR code to frontendmentor.io so you can show the image function in this case

  • CSS
    • it is not recommended to set font-size: 62.5%; read about it here
    • use min-height: 100vh; on body element so that in case of overflow it will allow scrolling
    • change the background color to match to the design

  Have a nice day👋!

  Marked as helpful

  1

  ---

  

  Shiash•100

  @klopropPosted almost 2 years ago

  @rostyslav-nazarenko Thanks for your feedbacks

  I always forget to add tags like main and footer , thanks for the reminder

  I see the point of using min-height but for the font size of 62.5%, I need time to digest and understand.

  1