Building page with grid

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  in the html <div class="social-media-icons"> should be out of <div class="hero__content">

  For the left and right sides spaces of the page, give .container a max-width of 1440px, a width of 80%, margin: 0 auto.

  .container{
  max-width:1440px;
  widtth: 80%;
  margin: 0 auto;
  }
  

  in the media query the background-image is not visible, to make it visible, add "./" to the beginning of the url value. url(./images/bg-desktop.svg) instead of url(images/bg-desktop.svg), give it a background-repeat of no repeat and background-size of cover.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1

  ---

  

  Shiash•100

  @klopropPosted almost 2 years ago

  @Hassiai Thanks for the feedback. Why setting the width to 80% is a better way? They both preserve spaces on the two sides of the screen.

  And can I set the max-width greater than 1440px? Why it is 1440 exclusively?

  0

  

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  @kloprop i choose 1440px for the max-width value because that is size of the screen that the screenshot of your challenge will be taken. for the width of 80% you can change it in the media query. in other personal project you can give the max-width any value you want.

  If its still confusing let me know so I can further clarify.

  0

  

  Shiash•100

  @klopropPosted almost 2 years ago

  @Hassiai But the width of the container is set to 80vw already, so why it needs to be set to 80% in the media query?

  0