Building NFT preview card using flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Rushikesh, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • remove all margin from card class because with flex they are superfluous
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • add transition on the element with hover effect

  Overall you did well! Hope this help 😁

  Marked as helpful

  1

  ---

  

  rushikesh•120

  @curator69Posted over 2 years ago

  @denielden really appreciate your feedback, will definitely work on the project as you said.

  1