Build with react

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the react's root node <div id="root"> with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! Your hard work and dedication are truly admirable. As you continue to hone your skills, here are a few suggestions that may be helpful:

  Keep practicing and learning new things. The more you challenge yourself, the more you'll grow as a developer. Seek feedback from others. It's always helpful to get a fresh perspective on your work and learn from constructive criticism. Collaborate with other developers. Working with others can help you learn new techniques and improve your coding skills. Again, congratulations on completing the challenge, and I wish you continued success in your coding journey! 😁

  0

  ---

  

  vinu cyril•980

  @vinumanPosted over 1 year ago

  @Kamlesh0007 Hello,

  Thank you for taking your time to paste a response. However, this is not a feedback for this solution but rather some general notes.

  I can see that you have taken an effort to copy paste the same thing under many other solutions as well. You are not helping anyone but might demotivate folks who are actually looking for feedbacks.

  Please do not be a spammer. Not cool!

  0

  

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  @vinuman bro i am not spamming I am only trying to appreciate ur efforts if u don't like what can i do

  0

  

  vinu cyril•980

  @vinumanPosted over 1 year ago

  @Kamlesh0007 Listen dude, you are SPAMMING. You are not helping anyone. This mindless copy paste does not help anyone, you might get some upvotes from newbies who would have thought that you have taken some time and effort to type something for them. But you have not!!

  You do not appreciate someone's effort by this COPY & PASTE.

  0