Build with modern CSS, Astro SSG and Mapbox custom designed map

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted about 2 years ago

  Hi Miran - another lovely and beautiful job here!!

  Well done on using Astro, I'm keen to try and have a go at using it one day. I love the transitions you've added to the buttons, very nice!

  I've very little I can add or suggest here. One thing is that when my mouse is over the map and I scroll the map zooms in and out, and I'd prefer to just scroll - this is especially the case on smaller screens where the map takes up more of the screen (but this is really a small issue).

  On a much more general level, you might like to have a look at some of the approaches set out in every-layout.dev. Some of it is pretty advanced CSS layout stuff, but I don't think it will be too difficult for you! I love the approach to a more 'intrinsic design' approach, and it reduces a lot of the need for media queries.

  Here's my solution of the same challenge that uses some of these approaches: https://www.frontendmentor.io/solutions/art-gallery-page-more-intrinsic-design-ESLbwbiu3t (my solution is no way as nice as yours, but I think I pretty much avoided break points completely in this challenge to create a more 'fluid' solution).

  Obviously, this just depends on what kind of approach you'd like to use for CSS, but I've come to really like this way of doing things.

  Keep up the lovely work! Very inspiring for me!

  Cheers Dave

  1

  ---

  

  Miran Legin•680

  @miranleginPosted about 2 years ago

  @dwhenson

  Hi Dave, thanks for taking the time and checking my solution.

  I agree that mouse wheel scrolling over the map can be annoying the say the least but i choose the lesser of two evils. I've disabled panning with finger/mouse because if that was allowed you wouldn't been able to scroll past header map in the Location page on mobile screen.

  I've read through the "Rudiments" section on the every-layout page you mentioned on some other challenge and i really like "Units" and "Modular Scale" sections.

  I've seen your take on this challenge and i saw that you had some issues with mix-blend-modes and text over dark background but could figure out how to fix it. I think the main issue was that text was not direct child of the background div or something like that.

  I also noticed that you are using way more custom properties for spacing than i am and that is something i need to work on more.

  Challenges on this platform are all following the same logic of spacing and aligning elements and someone clever enough would probably create macro layout system to handle any of these projects with a couple of smart predefined rules to apply everywhere.

  Thanks again for your kind words and see you on another challenge!

  Keep coding!

  Cheers, Miran

  1