Build a QR component by using HTML and CSS

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Swapna Maguluri, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the structure of the html document, prefer to wrap all the content with the main tag, since this challenge is just a component, it needs a main tag to know what the main content of the page is!

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  To improve the code structure wrap this div:

  <div class="attribution">

  with the semantic tag footer

  The rest is great!

  I hope it helps... 👍

  0
• 

  Saulius K.•560

  @TH3RIVPosted almost 2 years ago

  Hi, @Swapna-Maguluri!

  Your CSS looks nice and clean to me although I would suggest making the card a little smaller. Purely personal aesthetic reasoning.

  Now your HTML needs little bit of attention as it is missing little bit of semantic HTML:

  • Your card should be wrapped between <main></main> tags.
  • Your attribution should be wrapped between <footer></footer> tags.

  It doesn't change anything visually, but screen readers might have issues. It is considered good practice to use landmarks.

  Hope this helps!

  0