Design comparison
Solution retrospective
Any feedback will be most welcomed, especially areas to improve on. I think the final product didn't do justice to the design :) :)
Community feedback
- @shubhamthedevPosted over 4 years ago
Hi, the design looks great in my opinion specially the way you nailed responsiveness is great even i wasn't able to do that on this project. Some suggestions that i would make:
-
The font sizes seem to be a little to small specially on bigger screens.
-
The hero image looks a tad bit thin in the final design.
-
The mobile version of the site has a blank space on the top for some reason and I'm not sure if it's my browsers fault or not, since i read the code and couldn't figure out where that space is coming from.
-
You should color font inside the input element to pink.
-
Lastly you should fix the accessibility issues which i wouldn't say much about because i make those mistakes myself.
Those were some of my suggestions. Keep working hard and Happy Coding 👨💻.
2 -
- @adarshcodesPosted over 4 years ago
Hey! @NwosaEmeka, Great work on this solution👍, consider the modification recommended by tomboynotes
1 - @NwosaEmekaPosted over 4 years ago
Thanks a lot.. I will look at your suggestion and fix up. Thanks so much for the feedback
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord