Design comparison
SolutionDesign
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Mubaraq, It looks good!... You have some
issues
you need to fix.Document should have one main landmark
, Contain the component in<main>
.
<main> <section class="qr-section"> //... </section> </main>
-
Page should contain a level-one heading
, Changeh5
toh1
You should always have oneh1
per page of the document. -
I suggest you contain the attribution in
<footer>
.
<footer> <div class="attribution text-center mt-5"> //... </div> </footer>
I hope this is helpful to you... Keep coding👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord