Bootstrap and Custom CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Thidar Nyein, Congratulations on completing this challenge!

  The html markup for this solution its built entirely with <div>and you can improve it using semantics tags to describe what its inside each block of content. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  To add the two wave svg background images in the (top/bottom),, the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, to manage different images inside a single css property as background-image you use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those backgrounds applied:

  HERE'S YOUR CODE FIXED:

  body {
      background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg);
      background-position: left -185px top -236px, right 10px bottom -300px;
      background-repeat: no-repeat;
      background-attachment: fixed;
      background-size: contain, contain;
      background-position: left -185px top -236px, right 10px bottom -300px;
      /* background-repeat: no-repeat; */
      background-attachment: fixed;
      background-size: contain, contain;
      min-height: 100vh;
      /* font-family: 'League Spartan', sans-serif; */
      /* background: url(./images/bg-pattern-top-desktop.svg),url(./images/bg-pattern-bottom-desktop.svg) no-repeat no-repeat; */
      /* color: hsl(300, 43%, 22%); */
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0