Bootstrap

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @cashmerefrosh911, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  The main heading has the tag <h2>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

  Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Robert•50

  @shirosenseiPosted about 2 years ago

  Thanks for your input @correlucas, i will follow the hierarchy using the heading sequence like you suggested.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @cashmerefrosh911, some suggestions to improve you code:

  • Stay away from using libraries until you fully grasp the fundamentals. This is the purpose of this challenges.

  • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Add justify-content: center ; to your Body Element to correctly center your card to you page:

  • Delete the following to your .container. It is no longer needed.

  .container {
      box-align: center;
      margin: 0 auto;
  }
  

  • Change your max-width to max-width: 320px; to have the correct width.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Robert•50

  @shirosenseiPosted about 2 years ago

  Hi @vcarames, you just gave me alot of inspirations and i really appreciate it. i look forward to getting more advice/tips from you. Thank you one again.

  0