bootstrap

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @gdemartino93 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="carta">.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • It might be more efficient to use the <p> tag instead of <span>; the <p> element represents paragraph-level content, usually text:

  <p class="text-center text-secondary mb-3">  Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  

  • Use an h1 tag for your solution. The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page. Swap the <h2> tag with <h1>.

  <h1 class="text-center fw-bold fs-5 mb-3">  Improve your front-end skills by building projects</h1>
  

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  1

  ---

  

  Gianluca De Martino•100

  @gdemartino93Posted about 2 years ago

  @MelvinAguilar thanks for the tips but h1/2 has some default property from bootstrap and text wasnt the same.

  0