bootstrap 5 and javascript for responsive page landing

Community feedback

• 

  Mohamed Ehab•350

  @Programming-School-Pro-CodingPosted over 2 years ago

  Very Amazing Work Sir

  Congrats on finishing this project

  I have some suggestions:

  1. make the padding of the buttons are equal Because the button may be not cool
  2. remove the style closing tag
  3. the the outer section tag a outer main tag
  4. make all alt attributes have a content for the readers

  Do you understand ?

  I may help you with my suggestions

  Marked as helpful

  1
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Frontend Mentor challenges are arranged from Newbies which are the easier ones to Guru which are more complex. For people new to coding i encourage to start with the newbie challenges and work your way up after getting feedback from the slack channel and/or this site.

  • interactive elements such as buttons and anchor elements should have readable text, that is for the benefit of assistive technology users - they need to know the purpose/functions of the interactive element.
  • the first heading element of a site should be an h1 element and for best practice a site should have only one h1 heading element with heading elements in sequential order without skipping headings.
  • duplication of code especially in your html where you have content for mobile and another for desktop is not the best practice for Responsive web design - view your code with the css commented to see the structure of your html.
  • while bootstrap is an awesome library, it is something that you need to use when you are really comfortable with the basic css
  • in general the site is responsive

  Marked as helpful

  1

  ---

  

  Eji Cyril Arinze•220

  @Cyril-ArinzePosted over 2 years ago

  @ChamuMutezva Thank you for your feedback. i really appreciate and i promise to improve.

  0