Bookmark LP using React

Community feedback

• 

  Sven Feeleus•490

  @n3vsxPosted about 5 years ago

  That looks so crisp!!!

  1
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Hey Tiffany, it's nice to see you using this project to dive into React. As Phut mentioned, the live preview link currently isn't working so I can't see what you've built.

  But I did take a look at your code and here are a few suggestions:

  • For the hamburger toggle, you're grabbing each line individually and changing a class to make them animate. A simpler way of doing this would be to just add that class on the button itself and then animate the child elements based on the parent having/not having a class.
  • Instead of using state on class components, I'd recommend having a look into using Hooks. They actually clean up the code quite considerably!
  • For purely presentational components, using functional components instead of class components will remove some code.
  • Be sure not to forget about using semantic HTML5 structural elements like section and header. It's easy to revert to just using div elements when you start out using a component-based architecture, but they're still very important elements to use.

  I hope these pointers help. Keep up the great work and I'm looking forward to seeing your next solution! 👍

  1

  ---

  

  Tiffany Arellano•205

  @yiranoPosted about 5 years ago

  Oh how embarrassing! I didn't know I had to push directly into the main branch and had pushed into the gh-pages after a slight modification to the code.

  Thank you for these suggestions! I'm going to implement these changes now. :D

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @yirano haha, it's an easy mistake to make. Now that I can see the site, it looks awesome. Great work!

  0
• 

  Phut•455

  @phut-tranPosted about 5 years ago

  Hi @yirano, I couldn't see your live preview site. You may have a duplicate link in your submit solution.

  1

  ---

  

  Tiffany Arellano•205

  @yiranoPosted about 5 years ago

  Hi tdphut! Thank you for pointing this out. I had pushed directly into the gh-pages after making a slight change instead of pushing it to the main. I corrected the error so it should be working now!

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Hi, it's amazing. Great work so far. It would be great if you add some transitions on element. Then you can get smooth effects when you hover button and accordion. Anyway, it's perfect. :)

  0