Bookmark Landing Page using Sass with lots of Flexbox, Grid.

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Great work on completing this challenge Fab! It's a tricky layout and you've done an awesome job 👏👏👏

  Here are a few pointers after taking a look at your code:

  • In some instances, you're uppercasing text in your HTML, such as the nav items. I'd recommend against this, as screen readers will read these out letter-by-letter. Instead, I'd recommend writing them out lowercase, but then using text-transform: uppercase;to visually uppercase the text.
  • Nice work with the background patters as well. One way to clean up your HTML slightly here would be to use CSS pseudo-elements, like ::before instead of adding an empty HTML element.
  • You've currently got the . features__type class as an li element, but it doesn't have a ul as a parent, which is invalid HTML. I would recommend each of those items being a list item and then using an interactive element, like a button to set up the listener events to toggle the tabs.

  I hope these pointers help. Let me know if you have any questions! 🙂

  0

  ---

  

  Fab•135

  @fabcodingzestPosted about 5 years ago

  Thank you for the feedback Matt it really helps, I'd surely fix those things soon.🙂

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @fabrizvi you're welcome!

  0