Design comparison
SolutionDesign
Solution retrospective
So this challenge has been my first one using Webpack. Probably there are some mistakes with the related files but it works.. I’ve been struggling a lot with that and probably it is not the most efficient way to do it so please, let me know any advice.
I added some functionalities such as animations to the header when site is loaded and a sticky nav bar using Intersection Observer API.
Feel free to give any feedback. It will be appreciated 😊
Community feedback
- @ChamuMutezvaPosted over 3 years ago
Well done Yaiza
- you did well , the site is responsive.
- since the hamburger is supposed to be a button, you need to add wai-aria so that users of assistive technology can be able to use it without confusion.
<div class="hamburger" id="hamburger"> <span class="hamburger__line"></span> <span class="hamburger__line"></span> <span class="hamburger__line"></span> </div>- the alt values , i think there are not descriptive enough to again assist people who use assistive tech.
Awesome work
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord